Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Incorrect link in SQL Databases Tutorial (Alembic Note ) #10945

Closed
9 tasks done
Kludex opened this issue Jan 12, 2024 Discussed in #10944 · 1 comment
Closed
9 tasks done

[Docs] Incorrect link in SQL Databases Tutorial (Alembic Note ) #10945

Kludex opened this issue Jan 12, 2024 Discussed in #10944 · 1 comment
Labels
docs Documentation about how to use FastAPI good first issue Good for newcomers

Comments

@Kludex
Copy link
Sponsor Collaborator

Kludex commented Jan 12, 2024

Discussed in #10944

Originally posted by micallefdaniel January 12, 2024

First Check

  • I added a very descriptive title here.
  • I used the GitHub search to find a similar question and didn't find it.
  • I searched the FastAPI documentation, with the integrated search.
  • I already searched in Google "How to X in FastAPI" and didn't find any information.
  • I already read and followed all the tutorial in the docs and didn't find an answer.
  • I already checked if it is not related to FastAPI but to Pydantic.
  • I already checked if it is not related to FastAPI but to Swagger UI.
  • I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

  • I commit to help with one of those options 👆

Example Code

You can find an example of Alembic in a FastAPI project in the templates from [Project Generation - Template](../project-generation.md){.internal-link target=_blank}. Specifically in <a href="https://github.com/tiangolo/full-stack-fastapi-postgresql/tree/master/%7B%7Bcookiecutter.project_slug%7D%7D/backend/app/alembic/" class="external-link" target="_blank">the `alembic` directory in the source code</a>.

Description

Link to Alembic example in SQL Databases Tutorial is broken after merging Discard Cookiecutter PR.

<a href="https://github.com/tiangolo/full-stack-fastapi-postgresql/tree/master/%7B%7Bcookiecutter.project_slug%7D%7D/backend/app/alembic/" class="external-link" target="_blank">the `alembic` directory in the source code</a>.

Should be changed to:

<a href="https://github.com/tiangolo/full-stack-fastapi-postgresql/tree/master/src/backend/app/alembic" class="external-link" target="_blank">the `alembic` directory in the source code</a>.

Operating System

Linux, Windows, macOS

Operating System Details

N/A

FastAPI Version

0.109.0

Pydantic Version

2

Python Version

3.10

Additional Context

N/A

@Kludex Kludex added question Question or problem docs Documentation about how to use FastAPI good first issue Good for newcomers and removed question Question or problem labels Jan 12, 2024
@alejsdev
Copy link
Collaborator

This was solved in #10716 🪄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants