- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Microsoft Teams Notifier #2636
Conversation
Feat: Added Microsoft Teams Notifier
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2636 +/- ##
==========================================
+ Coverage 84.96% 85.00% +0.04%
==========================================
Files 102 103 +1
Lines 4721 4763 +42
==========================================
+ Hits 4011 4049 +38
- Misses 564 566 +2
- Partials 146 148 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see some issue in this PR, could you fix it?
CONTRIBUTING.md
Outdated
@@ -35,17 +36,17 @@ If you encounter any bugs or issues with the project, please [create a new issue | |||
|
|||
### Feature Requests | |||
|
|||
If you have a feature idea that you would like to see implemented, please [create a new issue](../../issues/new?assignees=&labels=enhancement%2Cneeds-triage&projects=&template=feature.yaml&title=(feature)+<title>) with the following information: | |||
If you have a feature idea that you would like to see implemented, please [create a new issue](<../../issues/new?assignees=&labels=enhancement%2Cneeds-triage&projects=&template=feature.yaml&title=(feature)+<title>>) with the following information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔨 issue: Why have you changed this file? Your changes are not necessary here.
cmd/relayproxy/config/notifier.go
Outdated
SlackWebhookURL string `mapstructure:"slackWebhookUrl" koanf:"slackWebhookUrl"` | ||
EndpointURL string `mapstructure:"endpointUrl" koanf:"endpointUrl"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔨 issue: koanf annotation expect a lower case name here, why have you changed it for slack and url endpoint? It has nothing to do with this PR.
cmd/relayproxy/config/notifier.go
Outdated
if c.Kind == MicrosoftTeamsNotifier && c.WebhookURL == "" { | ||
return fmt.Errorf("invalid notifier: no \"webhookURL\" property found for kind \"%s\"", c.Kind) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 praise: It is way better to use WebhookURL
here 👏
hello @thomaspoignant kindly review :) @thomaspoignant |
I still see changes in the contributing.md any reason why? |
@thomaspoignant i didn't touch the file |
Changes seems to come from you merge in this commit 7058977 BTW why did you merge the branch from @abdegenius and not the one from this repo? This is probably the reason why you have the issue. |
hey @thomaspoignant i have fix the issues please check my vscode was auto formatting on save |
hello @thomaspoignant kindly review :) |
hello @thomaspoignant any update |
I will do some clean up and merge the PR. |
alright sir anticipating :) |
8213d08
to
787b7c5
Compare
3f856af
to
84a813c
Compare
50c6a28
to
a5ccdc7
Compare
|
Description
Closes issue(s)
Checklist
README.md
and/website/docs
)