Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporter): Don't lock for non bulk exporter #2793

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

thomaspoignant
Copy link
Owner

Description

In this PR we stop using the slice storing the events for non-bulk exporter.
This is not needed because we call Export directly when we receive a featureEvent and it was causing delay when waiting on the Lock function of the mutex.

Closes issue(s)

Resolve #2792

Checklist

  • I have tested this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Sorry, something went wrong.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 149dec3
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/675c3c09b8c62000081ba760

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 48.57143% with 18 lines in your changes missing coverage. Please review.

Project coverage is 84.77%. Comparing base (9a9dbce) to head (149dec3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/data_exporter.go 48.57% 17 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2793      +/-   ##
==========================================
- Coverage   84.83%   84.77%   -0.06%     
==========================================
  Files         111      111              
  Lines        5184     5190       +6     
==========================================
+ Hits         4398     4400       +2     
- Misses        623      626       +3     
- Partials      163      164       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomaspoignant thomaspoignant merged commit e81df19 into main Dec 13, 2024
22 of 24 checks passed
@thomaspoignant thomaspoignant deleted the fix-2792 branch December 13, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) Random slower requests when evaluating flags with the OFREP API.
1 participant