feat: add phone login for embedded wallet #2366
Merged
+1,979
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: acded84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…github.com/thirdweb-dev/js into winston/add-phone-auth-for-embedded-wallet
|
/release-pr |
|
/release-pr |
…n/add-phone-auth-for-embedded-wallet
|
/release-pr |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2366 +/- ##
=======================================
Coverage 38.29% 38.29%
=======================================
Files 775 775
Lines 55983 55983
Branches 2528 2528
=======================================
Hits 21438 21438
Misses 33887 33887
Partials 658 658
*This pull request uses carry forward flags. Click here to find out more. |
|
/release-pr |
|
/release-pr |
…github.com/thirdweb-dev/js into winston/add-phone-auth-for-embedded-wallet
|
/release-pr |
|
/release-pr |
|
/release-pr |
|
/release-pr |
fix: phone otp validation chore: update placeholder text feat: allow phone / email to be shown first chore: allow space dashes and parenthesis
|
/release-pr |
MananTank
reviewed
Apr 5, 2024
legacy_packages/react/src/wallet/wallets/embeddedWallet/CountrySelector.tsx
Outdated
Show resolved
Hide resolved
jnsdls
requested changes
Apr 8, 2024
legacy_packages/react/src/evm/hooks/wallets/useEmbeddedWallet.ts
Outdated
Show resolved
Hide resolved
legacy_packages/react/src/wallet/wallets/embeddedWallet/CountrySelector.tsx
Outdated
Show resolved
Hide resolved
legacy_packages/react/src/wallet/wallets/embeddedWallet/embeddedWallet.tsx
Show resolved
Hide resolved
…github.com/thirdweb-dev/js into winston/add-phone-auth-for-embedded-wallet
jnsdls
approved these changes
Apr 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
Changes made
Public API changes:
embeddedWalletSdk.sendVerificationSms({ phoneNumber: "+11234567890" })embeddedWalletSdk.authenticate({ strategy: "phone_number_verification", verificationCode: "123456" })Internal API changes: explain the internal logic changes
How to test
PR-Codex overview
This PR adds the option to log in with SMS in the EmbeddedWallet feature. It includes changes related to email and phone login options, SMS verification, and validation functions.
Detailed summary