Use visibility argument when ::copy() in AWS adapters #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Sep 7, 2022
fnash
force-pushed
the
avoid-get-object-acl-in-copy
branch
from
2c5eea4
to
cb2a108
Compare
GromNaN
approved these changes
Sep 7, 2022
|
@frankdejonge Is it Okay for you? |
…ectAcl operation and permission)
fnash
force-pushed
the
avoid-get-object-acl-in-copy
branch
from
cb2a108
to
fcfa49d
Compare
|
@fnash can you base this PR on 3.x please? |
|
Okay! But need support for php7.4. Do I make another PR for 2.x? |
|
@fnash 2.x is in security fixes only mode as of a couple of months. |
|
I can see if I can make an exception, but that exposes me to more people who want an exception ... :/ |
|
That's kind of security issue since the visibility that is specified is not respected. |
|
I think you're exaggerating the issue now, but I'll look it I have time for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids
get-object-acloperation ands3:GetObjectAclpermission.