Fix SFTP retry mechanism #1451
Merged
Fix SFTP retry mechanism #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This path can never be executed.
|
I'll plan sometime to add tests to cover the issues I fixed 👍 |
As of phpseclib v3 `RuntimeException` objects are thrown, causing the whole retry logic to be bypassed. This makes sure to re-attempt to connect when timeout or connection issues happen.
lcobucci
force-pushed
the
fix-sftp-retries
branch
from
91eeb9c
to
b0b5a52
Compare
lcobucci
added a commit
to lcobucci/flysystem
that referenced
this pull request
Apr 21, 2022
This verifies that Flysystem SFTP adapter goes through all the configured tries before throwing an `UnableToConnectToSftpHost` exception. Reverting the fix applied in thephpleague#1451 makes the test to fail due to a unexpected `RuntimeException`. Applying this for phpseclib v2 is a bit tricky, though, due to the lack of knowledge on what has happened in the flow (e.g. `false` is returned when a connection cannot be established or when an authentication error happened). To make it work, the adapter for that version would need to verify if there's a connection or not all the time - which doesn't sound very good to me.
lcobucci
added a commit
to lcobucci/flysystem
that referenced
this pull request
Apr 22, 2022
This verifies that Flysystem SFTP adapter goes through all the configured tries before throwing an `UnableToConnectToSftpHost` exception. Reverting the fix applied in thephpleague#1451 makes the test to fail due to an unexpected `RuntimeException`. Applying this for phpseclib v2 is a bit tricky, though, due to the lack of knowledge on what has happened in the flow (e.g. `false` is returned when a connection cannot be established or when an authentication error happened). To make it work, the adapter for that version would need to verify if there's a connection or not all the time - which doesn't sound very good to me.
frankdejonge
pushed a commit
to thephpleague/flysystem-sftp-v3
that referenced
this pull request
Apr 24, 2022
This verifies that Flysystem SFTP adapter goes through all the configured tries before throwing an `UnableToConnectToSftpHost` exception. Reverting the fix applied in thephpleague/flysystem#1451 makes the test to fail due to an unexpected `RuntimeException`. Applying this for phpseclib v2 is a bit tricky, though, due to the lack of knowledge on what has happened in the flow (e.g. `false` is returned when a connection cannot be established or when an authentication error happened). To make it work, the adapter for that version would need to verify if there's a connection or not all the time - which doesn't sound very good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of phpseclib v3
RuntimeExceptionobjects are thrown, causing the whole retry logic to be bypassed.This makes sure to re-attempt to connect when timeout or connection issues happen.
FIxes #1450