fix(navbar): on Mobile Screen Navbar remains open even page is changed #1247
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
==========================================
- Coverage 99.54% 97.35% -2.20%
==========================================
Files 163 216 +53
Lines 6621 9224 +2603
Branches 401 538 +137
==========================================
+ Hits 6591 8980 +2389
- Misses 30 244 +214 ☔ View full report in Codecov by Sentry. |
|
what is LGTM @nigellima ? |
Looks Good To Me 😄 |
Understood!.. can you please approve the review again, please @nigellima |
|
@SutuSebastian can you please review the PR, and approve? |
SutuSebastian
force-pushed
the
fix/navbar-open-after-page-change
branch
from
b36a60e
to
cb6cfc4
Compare
|
@SutuSebastian , can you please help regarding the |
its just codecov going nuts again... |
Understood!.. I don't have to worry about it, right sir @SutuSebastian ? so I guess this PR had to be merge manually, if I am not wrong due to this check fail due to Codecov |
no, nothing from ur side, i'll merge it anyway, small changes |
When we go to the Mobile Screen and when we click on Navbar, it opens the Collapse, and when we click on any of the Link and it get redirected to another page, but Navbar Collapse isn't getting closed, it was only getting closed from Navbar Toggle nowhere else.
This fix is adding the onClick event to NavbarCollapse so whenever we click on the Link, it is closing the navbar.
Current:
Fixed:
