🐛 dynamically import node process #935
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowboyd
force-pushed
the
cl/dynamic-node-process
branch
from
e233431 to
a8c61c2
Compare
neurosnap
approved these changes
Dec 18, 2024
taras
approved these changes
Dec 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix #934
There were bundlers that were failing to process
main.tsbecause it was statically importing fromnode:processwhich is not available in all environments.Approach
This limits all the node specific code to the node branch of the host implementation. This node code will run only in the very specific instance that the main operation is running in node.