feat: Add react-native 0.78 support #578
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In react-native 0.78, they removed `StyleLength::unit()`. Instead, you can check `StyleLength::isUndefined()` directly, which achieves the same thing. Technically not backwards compatible, but I remember Janic saying the policy for new arch is to not be backwards compatible until it is stable and used by (pretty much) everyone.
|
I think it is fine to not be backwards compatible, but will have to release this as beta until 0.78 is stable. |
janicduplessis
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In react-native 0.78, they removed
StyleLength::unit(). Instead, you can checkStyleLength::isUndefined()directly, which achieves the same thing.Technically not backwards compatible, but I remember Janic saying the policy for new arch is to not be backwards compatible until it is stable and used by (pretty much) everyone.
Test Plan
Build an app with RN 78. Currently in RC.1