Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab): order tabIndex>0 before tabIndex=0 #809

Merged
merged 2 commits into from
Dec 13, 2021
Merged

fix(tab): order tabIndex>0 before tabIndex=0 #809

merged 2 commits into from
Dec 13, 2021

Conversation

ph-fritsche
Copy link
Member

What:

Change order of tabable elements.

Why:

Closes #807

Checklist:

  • Tests
  • Ready to be merged

Sorry, something went wrong.

@ph-fritsche ph-fritsche added this to the userEvent v14 milestone Dec 12, 2021
@ph-fritsche ph-fritsche linked an issue Dec 12, 2021 that may be closed by this pull request
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 12, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b4feb31:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #809 (b4feb31) into beta (eca157a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              beta      #809   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           77        77           
  Lines         1567      1575    +8     
  Branches       557       560    +3     
=========================================
+ Hits          1567      1575    +8     
Impacted Files Coverage Δ
src/utils/focus/getTabDestination.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eca157a...b4feb31. Read the comment docs.

@ph-fritsche ph-fritsche merged commit 1bc5945 into beta Dec 13, 2021
@ph-fritsche ph-fritsche deleted the fix-807 branch December 13, 2021 11:18
@github-actions
Copy link

🎉 This PR is included in version 14.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab order with tabIndex=0 and tabIndex>0
1 participant