Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keyboard): parse keyboard input without nesting #793

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

ph-fritsche
Copy link
Member

What:

Simplify the parsing and iterating through key defs.

Why:

Previous implementation nested calls. This could lead to RangeError: Maximum call stack size exceeded.

How:

Parse first and then iterate through parsed defs like the pointer implementation already does.

Checklist:

  • Tests
  • Ready to be merged

Sorry, something went wrong.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02b1332:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #793 (02b1332) into alpha (ca214d4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             alpha      #793   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           76        76           
  Lines         1542      1547    +5     
  Branches       575       572    -3     
=========================================
+ Hits          1542      1547    +5     
Impacted Files Coverage Δ
src/keyboard/index.ts 100.00% <100.00%> (ø)
src/keyboard/keyboardAction.ts 100.00% <100.00%> (ø)
src/keyboard/parseKeyDef.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca214d4...02b1332. Read the comment docs.

@ph-fritsche ph-fritsche merged commit df75e5f into alpha Nov 25, 2021
@ph-fritsche ph-fritsche deleted the fix-parsekeys branch November 25, 2021 13:53
@github-actions
Copy link

🎉 This PR is included in version 14.0.0-alpha.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant