feat(keyboard): add [Tab]
support
#767
Merged
+151
−122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add support for tabbing per
keyboard
.Why:
Missing default behavior.
How:
Took the implementation how to determine the tab destination from
userEvent.tab
.The new keyboard behaviorPlugin also selects the whole value if the tab destination is an
input
ortextarea
like the browser does.Checklist:
Additional information
I'm not sure the
focusTrap
option is needed (any more).It was introduced to allow using
userEvent.tab
withfocus-trap-react
injsdom
. See #193But at first glance there is nothing in the implementation of
focus-trap
that should not work out of the box.We might be able to remove this option. Then
userEvent.tab
could be reduced to be a convenience wrapper foruserEvent.keyboard('[Tab]')
.