Skip to content

Commit 2852509

Browse files
authoredAug 2, 2022
feat: separate input devices from pointer/keyboard API (#1003)
feat: * **pointer**: dispatch `auxclick` events fix: * **keyboard**: switch modifier state of lock keys on the correct event * **keyboard**: remove platform-specific additional key events for `Control` on `AltGraph` * **pointer**: dispatch `contextmenu` events with `detail: 0` * **pointer**: always set `PointerEvent.isPrimary` * **pointer**: set `button` property on pointer events separately from legacy mouse events * **pointer**: click closest common ancestor if `mousedown` and `mouseup` happen on different elements * **pointer**: omit click event on release if another button is released first * **pointer**: dispatch `mouseover`, `mouseenter` and `mousemove` on disabled elements * **pointer**: prevent `mouse*` events per `pointerdown` event handler * **pointer**: dispatch `*out` and `*over` events when moving into / out of nested elements * **pointer**: dispatch `*enter` and `*leave` events on ancestors
1 parent c6aafb7 commit 2852509

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+1562
-1304
lines changed
 

‎src/convenience/hover.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export async function hover(this: Instance, element: Element) {
88
export async function unhover(this: Instance, element: Element) {
99
assertPointerEvents(
1010
this[Config],
11-
this[Config].pointerState.position.mouse.target as Element,
11+
this[Config].system.pointer.getMouseTarget(this[Config]),
1212
)
1313
return this.pointer({target: element.ownerDocument.body})
1414
}

‎src/event/behavior/keydown.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,12 @@ const keydownBehavior: {
102102
}
103103
}
104104
},
105-
Tab: (event, target, {keyboardState}) => {
105+
Tab: (event, target, config) => {
106106
return () => {
107-
const dest = getTabDestination(target, keyboardState.modifiers.Shift)
107+
const dest = getTabDestination(
108+
target,
109+
config.system.keyboard.modifiers.Shift,
110+
)
108111
focus(dest)
109112
if (hasOwnSelection(dest)) {
110113
setUISelection(dest, {
@@ -121,7 +124,7 @@ const combinationBehavior: BehaviorPlugin<'keydown'> = (
121124
target,
122125
config,
123126
) => {
124-
if (event.code === 'KeyA' && config.keyboardState.modifiers.Control) {
127+
if (event.code === 'KeyA' && config.system.keyboard.modifiers.Control) {
125128
return () => selectAll(target)
126129
}
127130
}

0 commit comments

Comments
 (0)
Please sign in to comment.