-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Specify a non-* version for @types/react-dom #1040
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 76cda65:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to switch to peerDependencies
(see facebook/react#24304 (comment)) but this is a step in the right direction. Thanks!
Thanks, in the meantime I did the nuclear option... The CI errors seem to imply that there should be some things that need fixing, shall I update the PR to do that too? |
Codecov Report
@@ Coverage Diff @@
## main #1040 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 169 169
Branches 33 33
=========================================
Hits 169 169
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@all-contributors add @Nokel81 for bug and code |
I've put up a pull request to add @Nokel81! 🎉 |
🎉 This PR is included in version 13.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is broken, resulting in:
|
What: fixes #1039
Why: Updating to react@18 (including types) is broken when using
yarn
because it picks the wrong versionHow: Testing
Checklist:
docs site