Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manually trigger release #520

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

jgoz
Copy link
Collaborator

@jgoz jgoz commented Aug 22, 2023

What:

Empty commit.

Why:

Release changes from #519 because chore doesn't auto-release.

Checklist:

  • Documentation
  • Tests
  • Updated Type Definitions
  • Ready to be merged

@jgoz jgoz mentioned this pull request Aug 22, 2023
4 tasks
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #520 (2ba02c9) into main (61d17bd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #520   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          664       664           
  Branches       251       251           
=========================================
  Hits           664       664           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@IanVS
Copy link
Contributor

IanVS commented Aug 22, 2023

Out of curiosity, how is the version determined (major/minor/patch)? I'm guessing this should be released in a minor, not a patch, right?

@jgoz
Copy link
Collaborator Author

jgoz commented Aug 22, 2023

I think it's determined by the scope on the commit message once merged to main (fix, feat, etc).

I wasn't thinking of this as a new feature because I considered lack of proper ESM support to be a bug 😃, but I also don't feel strongly either way.

@nickmccurdy
Copy link
Member

Out of curiosity, how is the version determined (major/minor/patch)? I'm guessing this should be released in a minor, not a patch, right?

Ultimately it depends on SemVer, though I'll try to help make a decision. Is any of the work in #519 a breaking change, or is it just meant to restore functionality from Jest DOM 15 in a back compatible way?

@IanVS
Copy link
Contributor

IanVS commented Aug 22, 2023

There should be no breaking changes, and it's not restoring any functionality. It's publishing ESM modules for the first time, in addition to the CJS that was already being published previously.

@jgoz
Copy link
Collaborator Author

jgoz commented Aug 22, 2023

Neither a breaking change nor restoring functionality. This is also not really functionality at all, it's just different packaging (dual-publishing to esm/cjs instead of just cjs).

@IanVS
Copy link
Contributor

IanVS commented Aug 22, 2023

Jinx. ;)

@nickmccurdy
Copy link
Member

In that case I'd consider it SemVer minor, as it introduces a new API entry without affecting back compatibility.

@jgoz jgoz changed the title fix: manually trigger release feat: manually trigger release Aug 22, 2023
@jgoz
Copy link
Collaborator Author

jgoz commented Aug 22, 2023

@nickmccurdy Sounds good, changed to feat. Need another maintainer to approve now.

@nickmccurdy nickmccurdy merged commit 3d834bb into testing-library:main Aug 23, 2023
7 checks passed
@github-actions
Copy link

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@IanVS
Copy link
Contributor

IanVS commented Aug 23, 2023

Thanks! I guess it would be good to edit the release notes https://github.com/testing-library/jest-dom/releases/tag/v6.1.0 to include my PR that was not correctly titled (sorry, didn't know it needed a semantic title, maybe it would be good to add a check in CI for that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants