fix: handle multiple imports with no-manual-cleanup
#835
+21
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maisano
force-pushed
the
no-manual-cleanup-fix
branch
from
e6ce349 to
774797d
Compare
|
👋 Curious if I can get some eyes this, cc @Belco90 |
|
I'll try to review this next week. |
|
Hi hi – bumping this again! Should be a very quick review. The PR just accounts for when someone might have multiple testing library imports (which is common in my company's codebase). |
Belco90
approved these changes
Nov 9, 2023
|
🎉 This PR is included in version 6.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors please add @maisano for code and test |
|
I've put up a pull request to add @maisano! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
Crawl all the import references when sniffing out
no-manual-cleanupviolations.Context
There is currently a bug with
no-manual-cleanupwhere we only ever check the first import of anytesting-librarypackage. While duplicative imports of the same package is very likely uncommon, there are many packages within thetesting-libraryecosystem that will trip up the package detection and break this rule when we only look at the first.