Use defineProperty on the error object instead of setting the message… #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdeschryver
approved these changes
Sep 15, 2023
|
Thanks for the review! |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a0e916f:
|
Codecov Report
@@ Coverage Diff @@
## main #1261 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1038 1038
Branches 351 351
=========================================
Hits 1038 1038
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@all-contributors please add @julienw for code, bug |
|
I've put up a pull request to add @julienw! 🎉 |
eps1lon
pushed a commit
to eps1lon/dom-testing-library
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… directly
Fixes #1259
What: Use defineProperty on the error object instead of setting the message directly (Fixes #1259)
Why: With a DOMException, the error isn't propagated properly without this fix.
How: I used defineProperty instead of setting the message property directly.
Checklist:
Documentation added to the docs siteunneededTypeScript definitions updatedunneeded