MySQL add isRoot parameter to executeQuery
#882
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const queryResult = await container.executeQuery("SELECT 1 as res"); | ||
| expect(queryResult).toEqual(expect.stringContaining("res\n1\n")); | ||
|
|
||
| // Test root user | ||
| const rootQueryResult = await container.executeQuery("SELECT CURRENT_USER() as user"); |
There was a problem hiding this comment.
How does this test test the new isRoot parameter? Also please add a separate test
There was a problem hiding this comment.
Here we go, fixed. I apologise for the incomplete PR, I don't know what happened.
I kept the "test non-root and root in the same test" approach as is done in the "should work with database URI" test
cristianrgreco
added
enhancement
jeengbe
force-pushed
the
je-mysql-execute-query-root
branch
from
da1a560 to
b8118db
Compare
|
@jeengbe The new test is failing, could you take a look? |
|
It's weird that this test is failing; this implies that |
cristianrgreco
changed the title
isRoot parameter to executeQueryisRoot parameter to executeQuery
It's convenient to be able to perform root operations directly on the container. The parameter is optional and defaults to the current behaviour, so it's no breaking change.