Fix reuse support for CouchbaseContainer #9957
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
requested changes
Feb 17, 2025
There was a problem hiding this comment.
Hi @albihnf, thanks for your contribution. I've left some comments regarding the implementation. Also, please next time consider creating a branch for those changes, so, I can perform those.
modules/couchbase/src/main/java/org/testcontainers/couchbase/CouchbaseContainer.java
Outdated
Show resolved
Hide resolved
modules/couchbase/src/main/java/org/testcontainers/couchbase/CouchbaseContainer.java
Outdated
Show resolved
Hide resolved
eddumelendez
changed the title
eddumelendez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couchbase test container doesn't support reuse.
When starting it makes several http requests without using credentials and also tries to configure Couchbase again.
#2794
Solution was to overload appropriate methods and assume all configuration has been made if the container is being reused.