Fix wrong permission setup for HiveMQ container #8399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjgg
approved these changes
Feb 28, 2024
|
Hi @SgtSilvio can you add a test to reproduce the issue, please? |
|
@eddumelendez the issue happens with hivemq-ce version 2023.4 as it runs the container as a non-root user by default. So I updated the version used in the tests to 2023.4. I kept an older version in some tests to also cover older versions that run as the root user. |
Run some tests with an older hivemq-ce version as well
SgtSilvio
force-pushed
the
bugfix/hivemq-chmod
branch
from
190183b
to
ceb989e
Compare
eddumelendez
approved these changes
Feb 28, 2024
|
Thanks for your contribution, @SgtSilvio ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line
chmod -R 777 /opt/hivemq/extensionsis problematic when running the HiveMQ container with a non-root user.It is now made optional (removing it completely is not possible because older HiveMQ container images still need to be supported).