Add support for workdir and env var in exec command #7816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, only `user` and `command` can be used with `execInContainer`. This commit introduces `ExecConfig`, which allows to set workdir and env vars when running an exec process. `execInContainerWithUser` is deprecated in favor of `execInContainer(ExecConfig)`
|
Thanks for this @eddumelendez, appreciated. 🙏 I was about to fix a PR for this myself, since I just added support for these specific things (working dir and environment variables) in a custom method in my test class, but then I was puzzled when
Looking forward to see this being released as part of vNext. 👍 🎉 |
|
Could perhaps be worth adding to https://java.testcontainers.org/features/commands/ also, along with the new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only
userandcommandcan be used withexecInContainer.This commit introduces
ExecConfig, which allows to set workdir andenv vars when running an exec process.
execInContainerWithUseris deprecated in favor ofexecInContainer(ExecConfig)