Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Alternative waiting strategy for Mockserver container #6951

Conversation

DenilssonMontoya
Copy link
Contributor

Hi

As discussed in #6647, this PR changes the Waiting Strategy for Mockserver container so it becomes possible for it to work with HTTP and HTTPS requests.

Test cases were implemented to validate successful HTTPS requests to Mockserver, testing both cases when requests are made using TLS and mTLS which is described in Mockserver docs https://www.mock-server.com/mock_server/HTTPS_TLS.html

…rHttp for Wait.forLogMessage. This change will allow Mockserver to work with HTTP and HTTPS requests.
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddumelendez eddumelendez added this to the next milestone May 2, 2023
@eddumelendez eddumelendez merged commit cce90eb into testcontainers:main May 2, 2023
86 checks passed
@eddumelendez
Copy link
Member

Thank you so much for your contribution, @DenilssonMontoya ! This is now merged in main branch and it will be available as part of the next release.

@DenilssonMontoya
Copy link
Contributor Author

Thank you so much! Glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants