Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new section for test integrations #6930

Merged
merged 8 commits into from
Apr 21, 2023
Merged

Conversation

LeoColman
Copy link
Contributor

@LeoColman LeoColman commented Apr 19, 2023

This commit adds documentation on how Testcontainers can be integrated with the Kotest framework.

From the very old #2533 it was decided that a reference to Kotest would be great in the docs. This commit adds it.

@LeoColman LeoColman requested a review from a team as a code owner April 19, 2023 22:29
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I've left some comments

docs/test_framework_integration/kotest.md Outdated Show resolved Hide resolved
docs/test_framework_integration/kotest.md Outdated Show resolved Hide resolved
@eddumelendez eddumelendez added this to the next milestone Apr 20, 2023
LeoColman and others added 2 commits April 20, 2023 18:56
Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>
Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>
@LeoColman
Copy link
Contributor Author

Done :)

@eddumelendez
Copy link
Member

Hi @LeoColman, thinking more about this... I think we should not duplicate the existing documentation in kotest but we should point to it. what do you think about renaming the file to integration and then add Kotest with a link to https://kotest.io/docs/extensions/test_containers.html

The content can says something like The following open source projects use Testcontainers

@LeoColman
Copy link
Contributor Author

LeoColman commented Apr 21, 2023 via email

@eddumelendez
Copy link
Member

Just update this PR :)

@LeoColman
Copy link
Contributor Author

Alright, I renamed it to external and replaced the documentation with links to the module itself.

Also took the opportunity to add another integration from #3298 to the same page. <-- @jlink @gtrefs

@LeoColman
Copy link
Contributor Author

I thought of adding a last updated or last maintained to each of them, to prevent accidentally using a very old framework. Let me know what you think @eddumelendez

@eddumelendez eddumelendez changed the title Add Kotest to Test Framework Integrations Add new section for test integrations Apr 21, 2023
@eddumelendez eddumelendez merged commit 38fcf46 into testcontainers:main Apr 21, 2023
8 of 9 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution, @LeoColman ! This will be available soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants