Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude guava, jackson-core, jackson-databind from jib-core #6884

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

eddumelendez
Copy link
Member

@eddumelendez eddumelendez commented Apr 3, 2023

Previous to introduce support for Jib in f78c0c3. The dependencies
mentioned were shaded. However, after introducing Jib, those
transitive dependencies became part of the API. For that reason,
currently, those are not shaded.

In 1.17.6:
1 17 6

Currently:
currently without the changes in the PR

Including changes in this PR:
including the PR

Previous to introduce support for Jib in f78c0c3. The dependencies
mentioned were shaded. However, after introducing Jib, those
dependencies became part of the API. For that reason, currently,
those are not shaded.
@eddumelendez eddumelendez requested a review from a team as a code owner April 3, 2023 03:22
@eddumelendez
Copy link
Member Author

The other alternative is switching from provided to implementation

@kiview
Copy link
Member

kiview commented Apr 3, 2023

What is the impact on using implementation on those dependencies, such as Jackson?

And do understand correctly that the issue with our custom provided scope is, that all transitive dependencies of this provided dependency getting removed from the shaded dependencies?

@bsideup
Copy link
Member

bsideup commented Apr 3, 2023

However, after introducing Jib, those dependencies became part of the API

Could you please clarify this one? We might have to move Jib to a module if that's the case.

@bsideup
Copy link
Member

bsideup commented Apr 3, 2023

ohhh... I think I finally understand what happened! The shading logic does not consider provided's transitive dependencies as provided too and shades them.

An easy workaround would be to exclude all non-jib transitive dependencies of jib and re-add Jib as testImplementation (for testing)

@eddumelendez
Copy link
Member Author

eddumelendez commented Apr 3, 2023

ok. Thanks @bsideup !

@eddumelendez eddumelendez modified the milestones: 2.0, next Apr 3, 2023
@eddumelendez eddumelendez merged commit b51b7ed into main Apr 3, 2023
83 checks passed
@eddumelendez eddumelendez deleted the exclude_jib_deps branch April 3, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants