-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sharding support to MongoDBContainer #6727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @evanchooly ! I've left some comments. I already have those changes locally but can not push them to your branch (probably because is the main branch 🤔 )
modules/mongodb/src/test/java/org/testcontainers/containers/MongoDBContainerTest.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/test/java/org/testcontainers/containers/MongoDBContainerTest.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java
Outdated
Show resolved
Hide resolved
yeah, i noticed that after i pushed. a brainfart. should've done it on a branch. maybe with these edits, i'll move it off to a branch and recreate. but maybe it's not worth the effort. |
i think i have all the requested changes made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check fails because of an unused import. Also, please run ./gradlew :mongodb:check --no-daemon
modules/mongodb/src/test/java/org/testcontainers/containers/MongoDBContainerTest.java
Outdated
Show resolved
Hide resolved
I wasn't clear from your comments earlier if you wanted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evanchooly thanks! Just last comments before to merge it. Sorry about this, I'd applied them but do not have access.
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/test/java/org/testcontainers/containers/MongoDBContainerTest.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/test/java/org/testcontainers/containers/MongoDBContainerTest.java
Outdated
Show resolved
Hide resolved
apply PR feedback
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java
Outdated
Show resolved
Hide resolved
…ngoDBContainer.java
Thank you so much, @evanchooly ! For your contribution and patience :) This is now merge in |
yay! next time i'll use a branch. ;) |
Hello @evanchooly Potential fix: #7164 |
Adds sharding support but in its current form may not quite be The Testcontainers Way just yet. Happy to work with whomever to rearrange it to its correct form.