Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6667: reset network creation state if network creation fails. #6668

Merged
merged 1 commit into from
Mar 2, 2023
Merged

#6667: reset network creation state if network creation fails. #6668

merged 1 commit into from
Mar 2, 2023

Conversation

k-wall
Copy link
Contributor

@k-wall k-wall commented Feb 26, 2023

Reset network creation state if network creation fails. This allows any startAttempts that the user has applied to the container to retry the creation of the network too.

@k-wall
Fix testcontainers#6667: Reset network creation state if network crea…
65801bd 
…tion fails.

This allows any `startAttempts` that the user has applied to the container to retry the creation of the network too.

Signed-off-by: kwall <kwall@apache.org>
@k-wall k-wall requested a review from a team as a code owner February 26, 2023 11:55
@eddumelendez eddumelendez added this to the next milestone Mar 2, 2023
@eddumelendez eddumelendez merged commit fd1a624 into testcontainers:main Mar 2, 2023
@eddumelendez
Copy link
Member

Thanks for your contribution, @k-wall! This is now merged in main branch and it will be part of the next release.

@k-wall k-wall deleted the issue-30 branch March 2, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k-wall @eddumelendez @kiview