Selenium: increase default startup timeout to 60 seconds #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
previously approved these changes
Nov 28, 2023
modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java
Outdated
Show resolved
Hide resolved
modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java
Outdated
Show resolved
Hide resolved
|
Thanks for your contribution, @Aloren! Starting with next release the timeout will be 60 seconds for BrowserWebDriverContainer, which I think is fair enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Selenium takes more than 15 seconds to startup on the agents.
Unfortunately, I haven't found a good way to make startup timeout configurable without touching the constructor.
If you have an idea how to do that better please advise. Thank you.