Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: confirm support for new mongo images #2326

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It moves the existing examples to an examples_test.go file, creating a new one for testing that the given images are valid.

Why is it important?

Confirm the new MongoDB images are valid for the module.

@mdelapenya mdelapenya requested a review from a team as a code owner March 6, 2024 07:34
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Mar 6, 2024
@mdelapenya mdelapenya self-assigned this Mar 6, 2024
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 67b8c1a
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65e81c9740a17700084d26d5
😎 Deploy Preview https://deploy-preview-2326--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya merged commit cfd60e9 into testcontainers:main Mar 6, 2024
96 checks passed
@mdelapenya mdelapenya deleted the mongodb-images branch March 6, 2024 10:35
mdelapenya added a commit to JJCinAZ/testcontainers-go that referenced this pull request Mar 13, 2024
* main: (239 commits)
  Move the container and config tests into a test package (testcontainers#2242)
  Added error handling for context.Canceled in log reading code (testcontainers#2268)
  chore: updated docker compose version (testcontainers#2340)
  Add method for getting Weaviate's gRPC port (testcontainers#2339)
  chore: use withEnv in localstack module (testcontainers#2337)
  docs: fix wrong copy&paste (testcontainers#2338)
  fix: consul race on HTTP port (testcontainers#2336)
  chore(deps): bump mkdocs-material from 8.2.7 to 9.5.13 (testcontainers#2334)
  feat: add openfga module (testcontainers#2332)
  chore: retire dependabot (testcontainers#2325)
  chore: check that the new version is not empty (testcontainers#2331)
  chore: prepare for next minor development cycle (0.30.0)
  chore: use new version (v0.29.1) in modules and examples
  fix: incorrect version
  chore: prepare for next minor development cycle ()
  chore: use new version (v0.29.0) in modules and examples
  generic.go: GenericContainer(): clearer error message (testcontainers#2327)
  chore: confirm support for new mongo images (testcontainers#2326)
  Add k3s WithManifest option (testcontainers#1920)
  chore(deps): bump google.golang.org/grpc in /modules/qdrant (testcontainers#2281)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant