Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve module creation section #2239

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

mdelapenya
Copy link
Collaborator

@mdelapenya mdelapenya commented Feb 15, 2024

What does this PR do?

This PR improves the docs on how to create a module, adding the initial considerations regarding where to host a module before actually creating it.

Why is it important?

There is a big difference hosting a module in our repo compared to letting users to host them themselves. This PR sets the expectations for all the use cases: official modules, community modules and regular/core modules.

How to test this PR

Render URL: https://deploy-preview-2239--testcontainers-go.netlify.app/modules/

@mdelapenya mdelapenya requested a review from a team as a code owner February 15, 2024 12:37
@mdelapenya mdelapenya self-assigned this Feb 15, 2024
Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 1d41d38
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65ce05802b3d290008fe3c65
😎 Deploy Preview https://deploy-preview-2239--testcontainers-go.netlify.app/modules
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Feb 15, 2024
@mdelapenya mdelapenya merged commit ca7d668 into testcontainers:main Feb 15, 2024
7 checks passed
@mdelapenya mdelapenya deleted the community-modules branch February 15, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants