feat: support configuring Ryuk verbose mode at config level #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
added
the
feature
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* main: chore: lookup exposed ports in the image from Config, not from ContainerConfig (testcontainers#2039)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds
ryuk.verboseproperty to the Testcontainers property file to enable running Ryuk in verbose mode (see https://github.com/testcontainers/moby-ryuk/?tab=readme-ov-file#ryuk-configuration). It can be set there, or using theTESTCONTAINERS_RYUK_VERBOSE=trueenv var.Why is it important?
There are situations where we need to debug Ryuk, like being terminated too early. With this change, we will be able to tell Ryuk to run in verbose mode from testcontainers-go.
Related issues