Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neo4j license agreement customization options #2036

Merged
merged 2 commits into from Dec 22, 2023

Conversation

danielorbach
Copy link
Contributor

@danielorbach danielorbach commented Dec 20, 2023

What does this PR do?

This PR adds the ability to use the Neo4j Enterprise Edition docker image by setting the correct environment variable.

Why is it important?

Many production-ready users of Neo4j use the Enterprise edition. Some features can only be tested on the Enterprise edition.

Related issues

I haven't opened a concomitant Issue, @mdelapenya let me know if I should open one.

How to test this PR

Simply run a container with image tag enterprise (i.e. neo4j:enterprise) with the new option and see that the container does not crash immediately with the following error:

Details

In order to use Neo4j Enterprise Edition you must accept the license agreement.
  
  The license agreement is available at https://neo4j.com/terms/licensing/
  If you have a support contract the following terms apply https://neo4j.com/terms/support-terms/
  
  If you do not have a commercial license and want to evaluate the Software
  please read the terms of the evaluation agreement before you accept.
  https://neo4j.com/terms/enterprise_us/
  
  (c) Neo4j Sweden AB. All Rights Reserved.
  Use of this Software without a proper commercial license, or evaluation license
  with Neo4j, Inc. or its affiliates is prohibited.
  Neo4j has the right to terminate your usage if you are not compliant.
  
  More information is also available at: https://neo4j.com/licensing/
  If you have further inquiries about licensing, please contact us via https://neo4j.com/contact-us/
  
  To accept the commercial license agreement set the environment variable
  NEO4J_ACCEPT_LICENSE_AGREEMENT=yes
  
  To accept the terms of the evaluation agreement set the environment variable
  NEO4J_ACCEPT_LICENSE_AGREEMENT=eval
  
  To do this you can use the following docker argument:
  
          --env=NEO4J_ACCEPT_LICENSE_AGREEMENT=<yes|eval>

@danielorbach danielorbach requested a review from a team as a code owner December 20, 2023 18:51
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit a133992
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6584a533e1cbb60008e4a826
😎 Deploy Preview https://deploy-preview-2036--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the options require a specific Docker image for Neo4j? I'd like to have a test or a testable example demonstrating the usage of this options

@mdelapenya
Copy link
Collaborator

Oh I saw this late:

Simply run a container with image tag enterprise

What will happen when the options are passed with a non-enterprise image? Will that be a NOOP?

@danielorbach
Copy link
Contributor Author

What will happen when the options are passed with a non-enterprise image? Will that be a NOOP?

Yes indeed a no-op.

/to @mdelapenya

@mdelapenya
Copy link
Collaborator

What will happen when the options are passed with a non-enterprise image? Will that be a NOOP?

Yes indeed a no-op.

/to @mdelapenya

So then it's fine to pass the options in a non-enterprise image, right? Then, having a test/example would make it to be merged

@danielorbach
Copy link
Contributor Author

What will happen when the options are passed with a non-enterprise image? Will that be a NOOP?

Yes indeed a no-op.
/to @mdelapenya

So then it's fine to pass the options in a non-enterprise image, right? Then, having a test/example would make it to be merged

I've pushed some tests proving that @mdelapenya

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the test and for contributing to the module. Much appreciated!

@mdelapenya mdelapenya self-assigned this Dec 22, 2023
@mdelapenya mdelapenya added the enhancement New feature or request label Dec 22, 2023
@mdelapenya mdelapenya merged commit 1c45958 into testcontainers:main Dec 22, 2023
116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants