Add username and password functions to mongodb #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Nov 13, 2023
There was a problem hiding this comment.
Hi @ugrkm thanks for this! I added some comments before accepting the PR.
Could you take a look at them 🙏 ?
ugrkm
force-pushed
the
ugrkm-1908-add-username-and-password-funcs-mongodb
branch
from
0775e95
to
3482d48
Compare
mdelapenya
reviewed
Nov 14, 2023
ugrkm
force-pushed
the
ugrkm-1908-add-username-and-password-funcs-mongodb
branch
from
3482d48
to
905ec81
Compare
mdelapenya
added
the
feature
mdelapenya
reviewed
Nov 24, 2023
ugrkm
force-pushed
the
ugrkm-1908-add-username-and-password-funcs-mongodb
branch
from
905ec81
to
91e7872
Compare
mdelapenya
reviewed
Nov 28, 2023
ugrkm
force-pushed
the
ugrkm-1908-add-username-and-password-funcs-mongodb
branch
from
91e7872
to
04886f1
Compare
mdelapenya
approved these changes
Nov 28, 2023
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Nov 30, 2023
* main: (100 commits) fix: fallback matching of registry authentication config (testcontainers#1927) feat: support customizing the Docker build command (testcontainers#1931) docs: include MongoDB's username and password options into the docs (testcontainers#1930) feat: support for custom registry prefixes at the configuration level (testcontainers#1928) Add username and password functions to mongodb (testcontainers#1910) chore: skip TestContainerLogWithErrClosed as flaky on rootless docker (testcontainers#1925) docs: add some Vault module examples (testcontainers#1825) feat: support for executing commands in a container with user, workDir and env (testcontainers#1914) fix(modules.kafka): Switch to MaxInt for 32-bit support (testcontainers#1923) docs: fix code snippet for image substitution (testcontainers#1918) Add database driver note to SQL Wait strategy docs (testcontainers#1916) Reduce flakiness in ClickHouse tests (testcontainers#1902) lint: enable nonamedreturns (testcontainers#1909) chore: deprecate BindMount APIs (testcontainers#1907) fix(reaper): fix race condition when reusing reapers (testcontainers#1904) feat: Allow the container working directory to be specified (testcontainers#1899) chore: make rabbitmq examples more readable (testcontainers#1905) chore(deps): bump github.com/twmb/franz-go and github.com/twmb/franz-go/pkg/kadm in /modules/redpanda (testcontainers#1896) Fix - respect ContainerCustomizer in neo4j module (testcontainers#1903) chore(deps): bump github.com/nats-io/nkeys and github.com/nats-io/nats.go in /modules/nats (testcontainers#1897) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This will add username and password functions to mongodb module. I removed mongodb_test module and put the tests in mongodb module. Because this was the pattern for other modules like postgres and mariadb.
Why is it important?
This enables users to be able to configure username and password. Also, it creates feature parity with other modules.
Related issues
How to test this PR
I already created a test for the change in mongodb_test.go file.