Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support creating a network for localstack #1612

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

mdelapenya
Copy link
Member

What does this PR do?

This PR adds a functional option to the localstack module, making it possible to create a Docker network for it and run localstack in that network with a given alias.

Why is it important?

Support for running the localstack module in a network, as demo'ed in the existing tests.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner September 12, 2023 03:21
@mdelapenya mdelapenya added the feature New functionality or new behaviors on the existing one label Sep 12, 2023
@mdelapenya mdelapenya self-assigned this Sep 12, 2023
@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit a9546cb
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6500400d086657000844bf5c
😎 Deploy Preview https://deploy-preview-1612--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Member Author

As a follow up, this new functional option could be pushed to the core, and available to all the modules 🤔

@mdelapenya mdelapenya merged commit 4c6a989 into testcontainers:main Sep 12, 2023
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Sep 13, 2023
* main:
  feat: support creating a network for localstack (testcontainers#1612)
@mdelapenya mdelapenya deleted the localstack-network branch November 6, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Localstack]: automatically create a network for Localstack
1 participant