Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: embed code snippets for the artemis module #1502

Merged
merged 1 commit into from Aug 14, 2023

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It converts the current Go snippets into embedded snippets, using the codeinclude plugin.

Why is it important?

To not have outdated snippets, being executed as part of the test suite.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner August 14, 2023 11:57
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Aug 14, 2023
@mdelapenya mdelapenya self-assigned this Aug 14, 2023
@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 584db27
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64da168d5a74f40008d97f56
😎 Deploy Preview https://deploy-preview-1502--testcontainers-go.netlify.app/modules/artemis
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Collaborator Author

cc/ @abemedia

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya
Copy link
Collaborator Author

Merge, as the changes in here are properly rendered in the docs site, and it's not affecting the code

@mdelapenya mdelapenya merged commit d444c86 into testcontainers:main Aug 14, 2023
12 of 18 checks passed
@mdelapenya mdelapenya deleted the artemis-code-snippets branch August 14, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the code snippets using the codeinclude plugin for Artemis module
2 participants