chore: bump minimal Go version to 1.20 #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
added
chore
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Use rand.New instead
mdelapenya
added a commit
to abemedia/testcontainers-go
that referenced
this pull request
Aug 14, 2023
mdelapenya
added a commit
that referenced
this pull request
Aug 14, 2023
* feat(modules): add artemis container * chore: improve docs, use assert for tests * chore: bump Go to 1.20 See #1497 --------- Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Merging, as CI passed before the latest commit (resolving conflicts in ci.yml) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a shell script (and docs) to bump the Go version across all project files:
There is a few places in the Github actions that, instead of using a fixed Go version, the GH action to install Go uses a
go-version-fileproperty, pointing to thego.mod. Where possible, we are using it instead of a fixed version, so upcoming updates won't be needed in those cases. These places are:Why is it important?
Go 1.21 is out, and Go 1.19 was deprecated 2 days ago, so we needed to bump the versions, as GH workers are starting to use Go 1.21 when requesting Go 1.x.
Because there is an open issue to automate the process, I've included the script in the same PR to bump the versions.
Related issues
How to test this PR
Please run the following commands:
Bump Go to 1.21
./scripts/bump-go.sh "1.21"All affected files will be bumped.
Keep Go 1.20
./scripts/bump-go.sh "1.20"No files will be modified.
Downgrade Go to 1.19
./scripts/bump-go.sh "1.19"All affected files will be downgraded.