chore: Use generic db url for postgresql container #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we where using the PG specific url format but most tools would expect the url on the generic one (i.e https://github.com/golang-migrate/migrate). People could indeed write their own connString mapper but that would be unnecessary. (Ideally tools would not try to parse the url and instead just use the string but sometimes they might need to, thus using the generic format would work most of the times)
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kevinrobayna
commented
Aug 10, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
mdelapenya
reviewed
Aug 11, 2023
mdelapenya
approved these changes
Aug 11, 2023
kevinrobayna
added a commit
to Rotabot-io/rotabot
that referenced
this pull request
Aug 16, 2023
Since We did this change on testcontainer testcontainers/testcontainers-go#1493 we now can delete the internal helper. Less code to maintain == GOOD
kevinrobayna
added a commit
to Rotabot-io/rotabot
that referenced
this pull request
Aug 16, 2023
Since We did this change on testcontainer testcontainers/testcontainers-go#1493 we now can delete the internal helper. Less code to maintain == GOOD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use generic db url format with PG containers instead of PG specific one.
Why is it important?
Before we where using the PG specific url format but most tools would expect the url on the generic one (i.e https://github.com/golang-migrate/migrate).
People could indeed write their own connString mapper but that would be unnecessary. (Ideally tools would not try to parse the url and instead just use the string but sometimes they might need to, thus using the generic format would work most of the times)