Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass testcontainers-go version as HTTP header #1491

Merged

Conversation

mdelapenya
Copy link
Collaborator

@mdelapenya mdelapenya commented Aug 10, 2023

What does this PR do?

Pass the library version as HTTP header when calling Docker. We are going to use the User-Agent header for that.

Why is it important?

Enrich the requests to the Docker engine with more information from the caller.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner August 10, 2023 11:31
@mdelapenya mdelapenya added the enhancement New feature or request label Aug 10, 2023
@mdelapenya mdelapenya self-assigned this Aug 10, 2023
@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 7b955ba
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64d4f5fd94a2e10007d7a6d5
😎 Deploy Preview https://deploy-preview-1491--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya marked this pull request as draft August 10, 2023 13:25
Co-authored-by: Sergei Egorov <bsideup@gmail.com>
@mdelapenya mdelapenya marked this pull request as ready for review August 10, 2023 13:51
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya mdelapenya merged commit 2e85c30 into testcontainers:main Aug 11, 2023
112 checks passed
@mdelapenya mdelapenya deleted the add-user-agent-header-docker-calls branch August 11, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants