Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase timeout for go test and GH action steps #1475

Merged
merged 1 commit into from Aug 9, 2023

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It increases the max timeout for go test and for the GH action step that actually executes the tests.

Why is it important?

Avoid undesired max timeout reached, specially on Windows

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner August 9, 2023 16:20
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 9, 2023
@mdelapenya mdelapenya self-assigned this Aug 9, 2023
@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 5b97818
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64d3bccffe7bae000904f26e
😎 Deploy Preview https://deploy-preview-1475--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mdelapenya
Copy link
Collaborator Author

Merging, as it's needed for the Windows PoC

@mdelapenya mdelapenya merged commit 8655ed6 into testcontainers:main Aug 9, 2023
16 checks passed
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Aug 9, 2023
* main:
  chore: increase timeout for go test and GH action steps (testcontainers#1475)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Aug 10, 2023
* main: (29 commits)
  Add support for MongoDB testing module (testcontainers#1447)
  Support groups in dependabot updates (testcontainers#1459)
  chore: run modulegen tests on Windows (testcontainers#1478)
  Add default labels when Ryuk is disabled (testcontainers#1339)
  feat: add clickhouse module (testcontainers#1372)
  chore: increase timeout for go test and GH action steps (testcontainers#1475)
  chore: triple max timeout for the workflow run, which takes +10m (testcontainers#1474)
  chore(deps): bump github.com/aws dependencies in /modules/localstack (testcontainers#1472)
  chore(deps): bump Google emulators dependencies in /examples (testcontainers#1471)
  all: fix goroutine leaks (testcontainers#1358)
  chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (testcontainers#1427)
  chore(deps): bump github.com/tidwall/gjson from 1.14.4 to 1.15.0 in /modules/vault (testcontainers#1428)
  chore: add a GH action for release drafter (testcontainers#1470)
  chore(deps): bump mkdocs-material from 3.2.0 to 8.2.7 (testcontainers#1468)
  Add global testcontainers header to docs (testcontainers#1308)
  Simplify dependabot updates sorting (testcontainers#1460)
  feat: use credential helper in docker config, even if auth is empty in .docker/config.json (testcontainers#1079)
  chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (testcontainers#1457)
  Revert "chore: run Windows tests on a Linux container (testcontainers#1456)"
  chore: run Windows tests on a Linux container (testcontainers#1456)
  ...
@mdelapenya mdelapenya deleted the timeout-gha branch August 11, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant