Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dependabot updates sorting #1460

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Simplify dependabot updates sorting #1460

merged 1 commit into from
Aug 9, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Aug 9, 2023

Use the sorter capabilities to handle the sorting.
It uses the package-ecosystem and the directory.
I know that the result is a bit different from the actual.

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit d1de2d9
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64d339dd962dc500081802c7
😎 Deploy Preview https://deploy-preview-1460--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmorel-35 mmorel-35 changed the title Simplify updates sorting Simplify dependabot updates sorting Aug 9, 2023
@mmorel-35 mmorel-35 marked this pull request as ready for review August 9, 2023 06:28
@mmorel-35 mmorel-35 requested a review from a team as a code owner August 9, 2023 06:28
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya
Copy link
Collaborator

mdelapenya commented Aug 9, 2023

IIUC it will use gh-actions > gomod > pip, so the code is sorting by package-ecosystem too. I like it! TBH I considered enforcing the extras (gha, pip) first and then the go code, but thinking about it twice, why? 🙈

I do like this approach mode, as it's more deterministic than one based on a personal bias. Thanks for this!

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@mdelapenya
Copy link
Collaborator

My only concern (unrelated) is that any time the dependabot file is modified, it triggers an update 🤦 So be ready for YADW: Yet Another Dependabot Wave

@mdelapenya mdelapenya self-assigned this Aug 9, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 9, 2023
@mdelapenya mdelapenya merged commit 1c11707 into testcontainers:main Aug 9, 2023
106 checks passed
@mmorel-35 mmorel-35 deleted the mmorel-35-20230809 branch August 9, 2023 09:57
@mmorel-35
Copy link
Contributor Author

You shouldn't be concerned about this. Maybe the amount of allowed PR per module is too low or the check frequency too long.
The config need help you address every update as soon as possible. If there are new updates every time there is a problem with the configuration.

@mdelapenya
Copy link
Collaborator

I was expecting @dependabot to be smart enough to honour the monthly schedule, instead of triggering an update every time the file is modified, which happened today after this merge

mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Aug 9, 2023
* main:
  Simplify dependabot updates sorting (testcontainers#1460)
  feat: use credential helper in docker config, even if auth is empty in .docker/config.json (testcontainers#1079)
  chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (testcontainers#1457)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Aug 10, 2023
* main: (29 commits)
  Add support for MongoDB testing module (testcontainers#1447)
  Support groups in dependabot updates (testcontainers#1459)
  chore: run modulegen tests on Windows (testcontainers#1478)
  Add default labels when Ryuk is disabled (testcontainers#1339)
  feat: add clickhouse module (testcontainers#1372)
  chore: increase timeout for go test and GH action steps (testcontainers#1475)
  chore: triple max timeout for the workflow run, which takes +10m (testcontainers#1474)
  chore(deps): bump github.com/aws dependencies in /modules/localstack (testcontainers#1472)
  chore(deps): bump Google emulators dependencies in /examples (testcontainers#1471)
  all: fix goroutine leaks (testcontainers#1358)
  chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (testcontainers#1427)
  chore(deps): bump github.com/tidwall/gjson from 1.14.4 to 1.15.0 in /modules/vault (testcontainers#1428)
  chore: add a GH action for release drafter (testcontainers#1470)
  chore(deps): bump mkdocs-material from 3.2.0 to 8.2.7 (testcontainers#1468)
  Add global testcontainers header to docs (testcontainers#1308)
  Simplify dependabot updates sorting (testcontainers#1460)
  feat: use credential helper in docker config, even if auth is empty in .docker/config.json (testcontainers#1079)
  chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (testcontainers#1457)
  Revert "chore: run Windows tests on a Linux container (testcontainers#1456)"
  chore: run Windows tests on a Linux container (testcontainers#1456)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants