Support groups in dependabot updates #1459
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mmorel-35 thanks for this! Do you envision adding groups now? I'd like to read more about it and create logical groups (i.e. all the Google Cloud emulators could go together, or identify from previous PRs what deps are present in multiple modules). Would like to help me in identifying those groups? |
|
I don't want to add them necessarily now but in case you would try to add them manually in the dependabot file this would avoid an unexpected deletion when a new example or module is added. In the first time you could go manually, module by module for common providers for example |
💯 |
|
I think we could start with a group per module, having a wildcard An edge case could be a dependency that is present in multiple modules... but we already live in that world |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
What do you think about this @mdelapenya ? |
| @@ -39,6 +46,11 @@ func NewUpdate(example Example) Update { | |||
| Interval: updateSchedule, | |||
| Day: "sunday", | |||
| }, | |||
| Groups: Groups{ | |||
| "all": Group{ | |||
| Patterns: []string{"*"}, | |||
There was a problem hiding this comment.
Could you double check that this will generate:
groups:
all:
patterns:
- "*"and no:
groups:
all:
patterns:
- *🙏
From modules dir:
go run . --name questdb --image "questdb/questdb:latest" --title QuestDB --as-moduleThere was a problem hiding this comment.
Ok, that shall be alright
|
Kudos, SonarCloud Quality Gate passed!
|
|
Merge, thanks! 👏👏👏 |
* main: Support groups in dependabot updates (testcontainers#1459) chore: run modulegen tests on Windows (testcontainers#1478)
* main: Add support for MongoDB testing module (testcontainers#1447) Support groups in dependabot updates (testcontainers#1459) chore: run modulegen tests on Windows (testcontainers#1478) Add default labels when Ryuk is disabled (testcontainers#1339) feat: add clickhouse module (testcontainers#1372)
* main: (29 commits) Add support for MongoDB testing module (testcontainers#1447) Support groups in dependabot updates (testcontainers#1459) chore: run modulegen tests on Windows (testcontainers#1478) Add default labels when Ryuk is disabled (testcontainers#1339) feat: add clickhouse module (testcontainers#1372) chore: increase timeout for go test and GH action steps (testcontainers#1475) chore: triple max timeout for the workflow run, which takes +10m (testcontainers#1474) chore(deps): bump github.com/aws dependencies in /modules/localstack (testcontainers#1472) chore(deps): bump Google emulators dependencies in /examples (testcontainers#1471) all: fix goroutine leaks (testcontainers#1358) chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (testcontainers#1427) chore(deps): bump github.com/tidwall/gjson from 1.14.4 to 1.15.0 in /modules/vault (testcontainers#1428) chore: add a GH action for release drafter (testcontainers#1470) chore(deps): bump mkdocs-material from 3.2.0 to 8.2.7 (testcontainers#1468) Add global testcontainers header to docs (testcontainers#1308) Simplify dependabot updates sorting (testcontainers#1460) feat: use credential helper in docker config, even if auth is empty in .docker/config.json (testcontainers#1079) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (testcontainers#1457) Revert "chore: run Windows tests on a Linux container (testcontainers#1456)" chore: run Windows tests on a Linux container (testcontainers#1456) ...
Support groups in dependabot updates