Add support for MongoDB testing module #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces functionalities for MongoDB testing, achieving 3 main goals: 1. Added mongodb module, `github.com/testcontainers/testcontainers-go/modules/mongodb`, in `dependabot.yml` with a monthly update cycle. 2. Created new `.md` documentation file for this module, providing details on how to add MongoDB to the Go dependencies, how to use this module, the MongoDB module reference, and other related details. 3. Implemented test files to verify MongoDB connection and integration, and added a `Makefile` for test execution. Justification: This helps users in testing their mongodb related go functionalities, effectively and efficiently.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Could you remove in this PR the MongoDB example, located in |
sure :) |
mdelapenya
reviewed
Aug 7, 2023
mdelapenya
reviewed
Aug 7, 2023
mdelapenya
reviewed
Aug 8, 2023
The error message was updated to clarify its meaning in modules/mongodb/mongodb_test.go. It now specifically states "failed to get connection string" instead of "failed to get endpoint", which enhances the readability and precision in case of a related error occurrence."
mdelapenya
reviewed
Aug 9, 2023
This update corrects the MongoDB usage example in our documentation in file docs/modules/mongodb.md and improves the corresponding test case in modules/mongodb/mongodb_test.go. Previously, the reference to 'Creating a MongoDB container' in documentation was missing the actual code block. The test has been modified to highlight the container setup steps visually within the code, which enhances test readability. This helps developers understand how to use the MongoDB module more effectively."
mdelapenya
reviewed
Aug 9, 2023
mdelapenya
reviewed
Aug 9, 2023
mdelapenya
previously approved these changes
Aug 9, 2023
* main: Support groups in dependabot updates (testcontainers#1459) chore: run modulegen tests on Windows (testcontainers#1478)
|
Kudos, SonarCloud Quality Gate passed!
|
|
Because the mongo workflow passed, I'm merging this one now. @ravilushqa thank you so much for converting the example into a module. I'm going to update the existing conversion guide, given we changed the CI workflow. |
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Aug 10, 2023
* main: Add support for MongoDB testing module (testcontainers#1447) Support groups in dependabot updates (testcontainers#1459) chore: run modulegen tests on Windows (testcontainers#1478) Add default labels when Ryuk is disabled (testcontainers#1339) feat: add clickhouse module (testcontainers#1372)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Aug 10, 2023
* main: (29 commits) Add support for MongoDB testing module (testcontainers#1447) Support groups in dependabot updates (testcontainers#1459) chore: run modulegen tests on Windows (testcontainers#1478) Add default labels when Ryuk is disabled (testcontainers#1339) feat: add clickhouse module (testcontainers#1372) chore: increase timeout for go test and GH action steps (testcontainers#1475) chore: triple max timeout for the workflow run, which takes +10m (testcontainers#1474) chore(deps): bump github.com/aws dependencies in /modules/localstack (testcontainers#1472) chore(deps): bump Google emulators dependencies in /examples (testcontainers#1471) all: fix goroutine leaks (testcontainers#1358) chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (testcontainers#1427) chore(deps): bump github.com/tidwall/gjson from 1.14.4 to 1.15.0 in /modules/vault (testcontainers#1428) chore: add a GH action for release drafter (testcontainers#1470) chore(deps): bump mkdocs-material from 3.2.0 to 8.2.7 (testcontainers#1468) Add global testcontainers header to docs (testcontainers#1308) Simplify dependabot updates sorting (testcontainers#1460) feat: use credential helper in docker config, even if auth is empty in .docker/config.json (testcontainers#1079) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (testcontainers#1457) Revert "chore: run Windows tests on a Linux container (testcontainers#1456)" chore: run Windows tests on a Linux container (testcontainers#1456) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces functionalities for MongoDB testing, achieving 3 main goals:
Added mongodb module,
github.com/testcontainers/testcontainers-go/modules/mongodb, independabot.ymlwith a monthly update cycle.Created new
.mddocumentation file for this module, providing details on how to add MongoDB to the Go dependencies, how to use this module, the MongoDB module reference, and other related details.Implemented test files to verify MongoDB connection and integration, and added a
Makefilefor test execution.Justification:
This helps users in testing their mongodb related go functionalities, effectively and efficiently.
What does this PR do?
Why is it important?
Related issues