internal/testcontainersdocker: close unused client #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AlexanderYastrebov
pushed a commit
to zalando/skipper
that referenced
this pull request
Aug 6, 2023
* update testcontainers to fix goroutine leak (see testcontainers/testcontainers-go#1441) [changes](testcontainers/testcontainers-go@v0.20.1...d1c291e) * enable redis tests back Closes #2496 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando/skipper
that referenced
this pull request
Aug 6, 2023
* update testcontainers to fix goroutine leak (see testcontainers/testcontainers-go#1441) [changes](testcontainers/testcontainers-go@v0.20.1...d1c291e) * enable redis tests back Closes #2496 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando/skipper
that referenced
this pull request
Aug 6, 2023
* update testcontainers to fix goroutine leak (see testcontainers/testcontainers-go#1441) [changes](testcontainers/testcontainers-go@v0.20.1...d1c291e) * enable redis tests back Updates #2458 Closes #2496 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
|
Thank you. |
AlexanderYastrebov
added a commit
to zalando/skipper
that referenced
this pull request
Aug 6, 2023
* update testcontainers to fix goroutine leak (see testcontainers/testcontainers-go#1441) [changes](testcontainers/testcontainers-go@v0.20.1...d1c291e) * enable redis tests back Updates #2458 Closes #2496 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes unused docker client.
Why is it important?
Docker client uses idle connections and if it is not closed it triggers goroutine leak detector.
I've created #1358 previously but while it is in discussion I propose to fix this obvious case which would also be enough for our project, see zalando/skipper#2436
Related issues