Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default labels when Ryuk is disabled #1339

Merged
merged 11 commits into from
Aug 9, 2023
Merged

Add default labels when Ryuk is disabled #1339

merged 11 commits into from
Aug 9, 2023

Conversation

eddumelendez
Copy link
Member

@eddumelendez eddumelendez commented Jul 4, 2023

Currently, when Ryuk is disabled, no default labels are provided in the container.
This commit introduces the following default labels:

"org.testcontainers": "true",
"org.testcontainers.lang": "go",
"org.testcontainers.version": "0.22.0"

Also, for consistency with the other Testcontainers lang implementations,
label org.testcontainers=true is added.

For consistency with the other Testcontainers lang implementations,
label `org.testcontainers=true` should be added.
@eddumelendez eddumelendez requested a review from a team as a code owner July 4, 2023 14:52
@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit da9fe95
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64cd84767c3f68000857acf2
😎 Deploy Preview https://deploy-preview-1339--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eddumelendez eddumelendez changed the title Add org.testcontainers label Add default labels when Ryuk is disabled Jul 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

internal/testcontainersdocker/labels.go Outdated Show resolved Hide resolved
docker.go Outdated Show resolved Hide resolved
testcontainersdocker.LabelLang: "go",
testcontainersdocker.LabelVersion: internal.Version,
TestcontainerLabel: "true",
TestcontainerLabelIsReaper: "true",
Copy link
Collaborator

@mdelapenya mdelapenya Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should deprecate this TestcontainerLabelIsReaper variable, as there exists an internal one with the same key: testcontainersdocker.LabelReaper

mdelapenya
mdelapenya previously approved these changes Aug 2, 2023
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments, but other than that, LGTM, thanks!

@mdelapenya mdelapenya self-assigned this Aug 4, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 4, 2023
@mdelapenya
Copy link
Collaborator

/windows-test

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
eddumelendez and others added 2 commits August 4, 2023 17:05
Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @eddumelendez ! 🚀

@mdelapenya mdelapenya merged commit b908ddc into main Aug 9, 2023
206 checks passed
@mdelapenya mdelapenya deleted the add_tc_label branch August 9, 2023 18:05
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Aug 10, 2023
* main:
  Add support for MongoDB testing module (testcontainers#1447)
  Support groups in dependabot updates (testcontainers#1459)
  chore: run modulegen tests on Windows (testcontainers#1478)
  Add default labels when Ryuk is disabled (testcontainers#1339)
  feat: add clickhouse module (testcontainers#1372)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Aug 10, 2023
* main: (29 commits)
  Add support for MongoDB testing module (testcontainers#1447)
  Support groups in dependabot updates (testcontainers#1459)
  chore: run modulegen tests on Windows (testcontainers#1478)
  Add default labels when Ryuk is disabled (testcontainers#1339)
  feat: add clickhouse module (testcontainers#1372)
  chore: increase timeout for go test and GH action steps (testcontainers#1475)
  chore: triple max timeout for the workflow run, which takes +10m (testcontainers#1474)
  chore(deps): bump github.com/aws dependencies in /modules/localstack (testcontainers#1472)
  chore(deps): bump Google emulators dependencies in /examples (testcontainers#1471)
  all: fix goroutine leaks (testcontainers#1358)
  chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (testcontainers#1427)
  chore(deps): bump github.com/tidwall/gjson from 1.14.4 to 1.15.0 in /modules/vault (testcontainers#1428)
  chore: add a GH action for release drafter (testcontainers#1470)
  chore(deps): bump mkdocs-material from 3.2.0 to 8.2.7 (testcontainers#1468)
  Add global testcontainers header to docs (testcontainers#1308)
  Simplify dependabot updates sorting (testcontainers#1460)
  feat: use credential helper in docker config, even if auth is empty in .docker/config.json (testcontainers#1079)
  chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (testcontainers#1457)
  Revert "chore: run Windows tests on a Linux container (testcontainers#1456)"
  chore: run Windows tests on a Linux container (testcontainers#1456)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants