Add global testcontainers header to docs #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Kudos, SonarCloud Quality Gate passed!
|
cristianrgreco
previously approved these changes
Jul 3, 2023
mdelapenya
reviewed
Aug 4, 2023
mdelapenya
reviewed
Aug 4, 2023
mdelapenya
reviewed
Aug 4, 2023
mdelapenya
reviewed
Aug 4, 2023
mdelapenya
requested changes
Aug 4, 2023
leocross
dismissed stale reviews from cristianrgreco and eddumelendez
via
c7ad139
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
mdelapenya
reviewed
Aug 8, 2023
mdelapenya
previously approved these changes
Aug 8, 2023
There was a problem hiding this comment.
LGTM! Thanks!!
@leocross let's talk about improving the CSS for the tc-version block 🙏
|
Kudos, SonarCloud Quality Gate passed!
|
mdelapenya
approved these changes
Aug 9, 2023
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Aug 9, 2023
* main: chore(deps): bump github.com/tidwall/gjson from 1.14.4 to 1.15.0 in /modules/vault (testcontainers#1428) chore: add a GH action for release drafter (testcontainers#1470) chore(deps): bump mkdocs-material from 3.2.0 to 8.2.7 (testcontainers#1468) Add global testcontainers header to docs (testcontainers#1308)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Aug 10, 2023
* main: (29 commits) Add support for MongoDB testing module (testcontainers#1447) Support groups in dependabot updates (testcontainers#1459) chore: run modulegen tests on Windows (testcontainers#1478) Add default labels when Ryuk is disabled (testcontainers#1339) feat: add clickhouse module (testcontainers#1372) chore: increase timeout for go test and GH action steps (testcontainers#1475) chore: triple max timeout for the workflow run, which takes +10m (testcontainers#1474) chore(deps): bump github.com/aws dependencies in /modules/localstack (testcontainers#1472) chore(deps): bump Google emulators dependencies in /examples (testcontainers#1471) all: fix goroutine leaks (testcontainers#1358) chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (testcontainers#1427) chore(deps): bump github.com/tidwall/gjson from 1.14.4 to 1.15.0 in /modules/vault (testcontainers#1428) chore: add a GH action for release drafter (testcontainers#1470) chore(deps): bump mkdocs-material from 3.2.0 to 8.2.7 (testcontainers#1468) Add global testcontainers header to docs (testcontainers#1308) Simplify dependabot updates sorting (testcontainers#1460) feat: use credential helper in docker config, even if auth is empty in .docker/config.json (testcontainers#1079) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (testcontainers#1457) Revert "chore: run Windows tests on a Linux container (testcontainers#1456)" chore: run Windows tests on a Linux container (testcontainers#1456) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a global navigation to the documentation that mirrors the navigation on https://testcontainers.com
Why is it important?
Testcontainers is a cross-language project and many resources like the getting started article, guides and the modules library that are not specific to a language implementation are hosted one testcontainers.com. Adding a global header with consistent navigation between the project site and the language documentation will help new and existing users discover these resources.