-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostgreSQL 17 #4231
PostgreSQL 17 #4231
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have read about it as well. I do like the new incremental backups' functionality. |
9ad1ab4
to
01fc100
Compare
yes, running on pg17 locally without any problems but see tests failing in the pipeline now 😬 |
d686604
to
3a710a7
Compare
c6c4eec
to
16fe7aa
Compare
@JakobLichterfeld - ready for review |
Thanks! We will handle postgres in nix installs in #4227
Not sure if PostgreSQL 17 is available on freebsd for examle but we can keep it this way.
I do love the reduction of commands needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts!
As docs have been published already and users start installing with PostgreSQL 17 (https://tff-forum.de/t/teslamate-erfahrungs-und-datenthread/84179/2824?u=spongyhat) we should aim for a release soon. Guess you want to finish #4219 first? |
PostgreSQL 17 is mentioning a change in how functions are using search_path. "Functions used by expression indexes and materialized views that need to reference non-default schemas must specify a search path during function creation."
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=2af07e2f7
OOTB earthdistance is not specifying a search path causing migration failures as earth_box and ll_to_earth have been used in indexes (they aren't any longer).
Therefore:
And as last indexes involing ll_to_earth / earth_box have been dropped in
20200502140646_drop_unused_indexes.exs
/20191007105010_add_new_fkey_indexes.exs
:20191008191431_fix_ll_to_earth.exs
)Updated Solution is taken from here (Adrian mentioned this issue back in 2019 as well):
Next to upgrading to PostgreSQL 17 I changed / updated some install docs as well to stay in line with currently supported / recommended versions of Grafana & Postgres.
Updated Restore instructions have been tested successfully on my instance.
PostgreSQL issue discussion: https://postgrespro.com/list/thread-id/2377019