Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable traffic flow from SCC to COS is added #525

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Conversation

Ak-sky
Copy link
Member

@Ak-sky Ak-sky commented Sep 4, 2024

Description

Added SCC network zone in the COS rule context to allow traffic flow from SCC -> COS.

Git Issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content
  • Allowed traffic from SCC to COS with private endpoint.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

Sorry, something went wrong.

@Ak-sky Ak-sky changed the title feat: cos enf mode enabled and SCC to COS added feat: cos enforcement mode is enabled by default and traffic flow from SCC to COS is added Sep 4, 2024
@Ak-sky Ak-sky changed the title feat: cos enforcement mode is enabled by default and traffic flow from SCC to COS is added feat: cos rule enforcement mode is set to be enabled by default and traffic flow from SCC to COS is added Sep 4, 2024
@Ak-sky
Copy link
Member Author

Ak-sky commented Sep 5, 2024

/run pipeline

Copy link
Member

@maheshwarishikha maheshwarishikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/fscloud/main.tf Outdated Show resolved Hide resolved
@Ak-sky
Copy link
Member Author

Ak-sky commented Sep 6, 2024

/run pipeline

@Ak-sky Ak-sky changed the title feat: cos rule enforcement mode is set to be enabled by default and traffic flow from SCC to COS is added feat: Enable traffic flow from SCC to COS is added Sep 6, 2024
@Ak-sky
Copy link
Member Author

Ak-sky commented Sep 10, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Sep 10, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Sep 11, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Sep 12, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Sep 12, 2024

/run pipeline

@vburckhardt vburckhardt merged commit 789366a into main Sep 12, 2024
2 checks passed
@vburckhardt vburckhardt deleted the enf-mode-cos branch September 12, 2024 09:27
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants