Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: workload_identity - add image pull secrets #2276

Conversation

emalihin
Copy link
Contributor

@emalihin emalihin requested review from apeabody, ericyz and a team as code owners February 11, 2025 17:22
Copy link

google-cla bot commented Feb 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@emalihin emalihin force-pushed the feat/wid-add-image-pull-secrets branch from b58dc08 to e1312a3 Compare February 11, 2025 17:24
@emalihin emalihin changed the title Feat/wid add image pull secrets feat: workload_identity - add image pull secrets Feb 11, 2025
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Feb 11, 2025
@emalihin
Copy link
Contributor Author

what's the output of terraform-google-kubernetes-engine-int-trigger (cloud-foundation-cicd) job?

@apeabody
Copy link
Collaborator

what's the output of terraform-google-kubernetes-engine-int-trigger (cloud-foundation-cicd) job?

Hi @emalihin - Looks like the same issue as #2227 (comment)

@emalihin
Copy link
Contributor Author

thanks @apeabody, is there any action I need to take?

@apeabody
Copy link
Collaborator

thanks @apeabody, is there any action I need to take?

Not currently - I've opened #2277 to investigate.

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @emalihin!

@emalihin
Copy link
Contributor Author

The check seems to have failed again 👀

@apeabody
Copy link
Collaborator

The check seems to have failed again 👀

Yes, that one was a flake, re-triggered it.

@apeabody
Copy link
Collaborator

/gcbrun

@emalihin
Copy link
Contributor Author

@apeabody had to rebase..

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody merged commit 8d5c9a4 into terraform-google-modules:main Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants