feat(TPG >= 4.46)!: adds support to autoclass

[fernandoiury]

This PR provides the autoclass feature for both multiple_buckets and simple_bucket.

Closes #220

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[apeabody]

/gcbrun

[fernandoiury]

@apeabody I just fixed lint. It's passing locally now. TIA

[apeabody]

/gcbrun

[fernandoiury]

@apeabody sorry I don't know the whole process. Do I have to do anything else or just wait for the reviewers for now? TIA

[apeabody]

@apeabody sorry I don't know the whole process. Do I have to do anything else or just wait for the reviewers for now? TIA

Hi @fernandoiury - Yes, typically wait for the reviewers, but I'll take a quick look at it now.

[apeabody]

Thanks for the contribution @fernandoiury! A few notes:

Please bump the minimum TPG version to the first which includes autoclass:

• https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/versions.tf#L23
• https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/modules/simple_bucket/versions.tf#L23

We should also exercise the new option in a test covered by the CI tests. Basically just enable it for one of these examples:

• https://github.com/terraform-google-modules/terraform-google-cloud-storage/tree/master/examples

[fernandoiury]

• Versions bumped
• Added autoclass = true to one of the examples
• fixed docs / updated metadata

[apeabody]

/gcbrun

[apeabody]

Thanks for the contribution @fernandoiury - LGTM

As this requires a bump to minimum TPG (breaking change), I'll first release 4.0.1.

[apeabody]

/gcbrun