feat!: Add matches_prefix and matches_suffix conditions #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmaupin
force-pushed
the
zmaupin/add-support-for-more-conditions
branch
5 times, most recently
from
57fe5c4
to
dc0f1ab
Compare
bharathkkb
reviewed
Dec 6, 2022
bharathkkb
changed the title
zmaupin
force-pushed
the
zmaupin/add-support-for-more-conditions
branch
2 times, most recently
from
6e0a2f1
to
c6cd629
Compare
|
@bharathkkb Hello! Is there anything I can do to help move this forward? |
zmaupin
force-pushed
the
zmaupin/add-support-for-more-conditions
branch
from
c6cd629
to
6dc8e98
Compare
bharathkkb
reviewed
Dec 13, 2022
examples/simple_bucket/main.tf
Outdated
| with_state = "ANY" | ||
| age = 365 | ||
| with_state = "ANY" | ||
| matches_prefix = [var.project_id] |
There was a problem hiding this comment.
I believe this should now be just a string? Tests are failing with
TestAll/examples/simple_bucket 2022-12-12T17:57:50Z command.go:185: Error: Invalid function argument
TestAll/examples/simple_bucket 2022-12-12T17:57:50Z command.go:185:
TestAll/examples/simple_bucket 2022-12-12T17:57:50Z command.go:185: on ../../modules/simple_bucket/main.tf line 75, in resource "google_storage_bucket" "bucket":
TestAll/examples/simple_bucket 2022-12-12T17:57:50Z command.go:185: 75: matches_prefix = contains(keys(lifecycle_rule.value.condition), "matches_prefix") ? split(",", lifecycle_rule.value.condition["matches_prefix"]) : null
TestAll/examples/simple_bucket 2022-12-12T17:57:50Z command.go:185: ├────────────────
TestAll/examples/simple_bucket 2022-12-12T17:57:50Z command.go:185: │ lifecycle_rule.value.condition["matches_prefix"] is tuple with 1 element
TestAll/examples/simple_bucket 2022-12-12T17:57:50Z command.go:185:
TestAll/examples/simple_bucket 2022-12-12T17:57:50Z command.go:185: Invalid value for "str" parameter: string required.
73af305
to
de6c9db
Compare
Update versions.tf to use minimum provider version `4.31` Update simple_bucket module to include matches_prefix and matches_suffix conditions.
zmaupin
force-pushed
the
zmaupin/add-support-for-more-conditions
branch
from
de6c9db
to
ddec583
Compare
|
@zmaupin |
|
@bharathkkb I figured out the problem. Looks like things are all passing now! |
bharathkkb
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.