Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhancing VPC Security with Amazon VPC Block Public Access #1159

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Jan 26, 2025

Description

PR add support for VPC Block Public Access exclusions and VPC Block Public Access options

Motivation and Context

Resolves #1158

Breaking Changes

It doesn't break backwards compatibility with the current major version

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
lukekarrys Luke Karrys
…, aws_vpc_block_public_access_exclusion
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, there are a few comments.

sebastianczech and others added 11 commits January 27, 2025 23:09
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
…cess-exclusion-1158
…cess-exclusion-1158
@sebastianczech
Copy link
Contributor Author

@antonbabenko thanks for your comments, I fixed all of them. If you could take a look once again, I will be grateful. Thanks.

@garym-krrv
Copy link

Commenting to track PR. Keen to start using this in the module

Thanks All

@antonbabenko antonbabenko merged commit 387f5ee into terraform-aws-modules:master Feb 12, 2025
19 checks passed
@antonbabenko
Copy link
Member

Thank you for the contributions @sebastianczech !

antonbabenko pushed a commit that referenced this pull request Feb 12, 2025
## [5.19.0](v5.18.1...v5.19.0) (2025-02-12)

### Features

* Enhancing VPC Security with Amazon VPC Block Public Access ([#1159](#1159)) ([387f5ee](387f5ee))
@antonbabenko
Copy link
Member

This PR is included in version 5.19.0 🎉

@garym-krrv
Copy link

Going to need a change to the module. Unable to set the Name on the bpa exclusion. I will take a look

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for VPC Block Public Access exclusions
3 participants